Benjamin Berg <benjamin@xxxxxxxxxxxxxxxx> writes: > ath10k_hw_qca988x_set_coverage_class needs to hold both conf_mutex and > the data_lock spin lock for parts of the function. However, data_lock > is only needed while storing the coverage_class to store the value that > the card is configured to. > > Fix the locking issue by only holding data_lock for the required duration. > > Signed-off-by: Benjamin Berg <benjamin@xxxxxxxxxxxxxxxx> Thanks, I also folded this with the patch in the pending branch. > And yes, I fully agree with your points of it being rather fragile. But as > you said, it should be entirely safe if not used. That's good. > Obviously a firmware implementation would be preferential. That's a shame as this feature is quite often requested. But if the firmware ever starts supporting the featrue we can then remove this hack from ath10k. > This locking issue was pretty unnecessary. Lets see if any more issues show > up in a closer review. I can't see the locking problem anymore so it seems to be fixed. I'll fix some minor things and send v2. I'll also CC linux-wireless. -- Kalle Valo
