Search Linux Wireless

Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Thumshirn <jthumshirn@xxxxxxx>, Solomon Peachy <pizza@xxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Fri, 30 Sep 2016 14:29:39 +0200
Cc: linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1475237495-15030-1-git-send-email-jthumshirn@suse.de> (sfid-20160930_141208_240938_8F56ACB3)
References: <1475237495-15030-1-git-send-email-jthumshirn@suse.de> (sfid-20160930_141208_240938_8F56ACB3)

> +	tmp = krealloc(buf->begin, size, GFP_KERNEL | GFP_DMA);
> +	if (tmp) {
> 
I think that check is inverted?

johannes

Follow-Ups:
- Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
  - From: Johannes Thumshirn

References:
- [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
  - From: Johannes Thumshirn

Prev by Date: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Next by Date: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Previous by thread: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Next by thread: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]

Powered by Linux