Hi Rob, > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Tuesday, September 20, 2016 2:58 AM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > devicetree@xxxxxxxxxxxxxxx; Wei-Ning Huang; Xinming Hu > Subject: Re: [PATCH] mwifiex: parse device tree node for PCIe > > On Fri, Sep 09, 2016 at 08:47:34PM +0530, Amitkumar Karwar wrote: > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > This patch derives device tree node from pcie bus layer framework. > > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > > marvell-8xxx.txt) to accomodate PCIe changes. > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > .../bindings/net/wireless/marvell-8xxx.txt | 64 > ++++++++++++++++++++++ > > .../bindings/net/wireless/marvell-sd8xxx.txt | 63 ------------- > -------- > > Resend using -M option so I do have to figure out if you added 1 line or > changed a bunch. > > > drivers/net/wireless/marvell/mwifiex/pcie.c | 19 +++++++ > > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 3 +- > > 4 files changed, 85 insertions(+), 64 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > > delete mode 100644 > > Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt > > > > diff --git > > a/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > > b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > > new file mode 100644 > > index 0000000..a8a95aa > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > > @@ -0,0 +1,64 @@ > > +Marvell 8897/8997 (sd8897/sd8997/pcie8997) SDIO/PCIE devices > > +------ > > + > > +This node provides properties for controlling the marvell sdio/pcie > wireless device. > > +The node is expected to be specified as a child node to the SDIO/PCIE > > +controller that connects the device to the system. > > + > > +Required properties: > > + > > + - compatible : should be one of the following: > > + * "marvell,sd8897" > > + * "marvell,sd8997" > > + * "marvell,pcie8997" > > PCIe uses vendor and product IDs for compatible strings. Please read the > OF PCI bus bindings doc. > Thanks for review. I have submitted updated version(V3) with this change. Regards, Amitkumar Karwar
