Search Linux Wireless

Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Larry Finger <Larry.Finger@xxxxxxxxxxxx>, kvalo@xxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Sat, 24 Sep 2016 10:43:07 -0700
Cc: devel@xxxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx
In-reply-to: <1474736239-9826-3-git-send-email-Larry.Finger@lwfinger.net>
References: <1474736239-9826-1-git-send-email-Larry.Finger@lwfinger.net> <1474736239-9826-3-git-send-email-Larry.Finger@lwfinger.net>

On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote:
> The entries in this enum may be referenced in debug output. Adding explicit
> values simplifies the lookup.

A negative aspect to this style is forced renumbering
if a HW_VAR entry is inserted.

Is that possible?

Follow-Ups:
- Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
  - From: Larry Finger

References:
- [PATCH 0/2] rtlwifi: Add missing values to case statements and simplify debugging
  - From: Larry Finger
- [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
  - From: Larry Finger

Prev by Date: Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages
Next by Date: Re: [PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines
Previous by thread: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
Next by thread: Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]

Powered by Linux