Search Linux Wireless

Re: [PATCH 15/37] wireless: use get/put_endian helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-05-29 at 14:35 -0700, Harvey Harrison wrote:
> On Thu, 2008-05-29 at 23:31 +0200, Johannes Berg wrote:
> > > -	ADM8211_CSR_WRITE(BSSID0, le32_to_cpu(*(__le32 *)bssid));
> > > +	ADM8211_CSR_WRITE(BSSID0, get_le32((__le32 *)bssid));
> > 
> > Maybe I'm stupid, but isn't this the same as le32_to_cpup? Or does
> > get_le32 handle unaligned values?

> You're not stupid, but there is a new put_le32 as well that takes
> aligned values similar to the put_unaligned_le32, so get_le32 was
> added to have an analog to get_unaligned_le32 as well.

So this is just to make the API "complete"? Are we removing le32_to_cpup
and the associated API then?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux