Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> I guess some of these static variables could be also const, but >> didn't check. > > I think both bitrates and channels can't be, due to cfg80211 writing > some (global) flags there on init. Sorry, I was unclear. I meant the whole file, not just what was in my mail: qtnfmac/cfg80211.c:static struct ieee80211_rate qtnf_rates[] = { qtnfmac/cfg80211.c:static struct ieee80211_channel qtnf_channels_2ghz[] = { qtnfmac/cfg80211.c:static struct ieee80211_supported_band qtnf_band_2ghz = { qtnfmac/cfg80211.c:static struct ieee80211_channel qtnf_channels_5ghz[] = { qtnfmac/cfg80211.c:static struct ieee80211_supported_band qtnf_band_5ghz = { qtnfmac/cfg80211.c:static struct cfg80211_ops qtn_cfg80211_ops = { qtnfmac/pcie.c:static struct qtnf_bus_ops qtnf_pcie_bus_ops = { qtnfmac/pcie.c:static struct attribute *qtnf_sysfs_entries[] = { qtnfmac/pcie.c:static struct attribute_group qtnf_attrs_group = { qtnfmac/pcie.c:static struct pci_device_id qtnf_pcie_devid_table[] = { qtnfmac/pcie.c:static struct pci_driver qtnf_pcie_drv_data = { Anyway, nothing important. Just something which I started to wonder while reading the code. -- Kalle Valo