On 09/15/2016 10:59 AM, Ben Greear wrote:
On 09/15/2016 10:34 AM, Grumbach, Emmanuel wrote:
I have other patches that remember the last 100 or so firmware log messages from the kernel and provide that in a binary dump image when firmware crashes. This is indeed very useful. But, when debugging non-crash occasions, it is still useful to see what the firmware is doing. For instance, maybe it is reporting lots of tx-hangs and/or low-level resets. This gives you a clue as to why a user might report 'my wifi sucks'. Since I am both FW and driver team for my firmware variant, and my approach has been working for me, then I feel it is certainly better than the current state. And just maybe the official upstream FW team could start using something similar as well. Currently, I don't see how they can ever make much progress on firmware crashes reported in stock kernels.
I forgot the other good reason about console logging this: Sometimes ath10k firmware crash causes the entire kernel to crash, so there is no time to grab the binary dump from a file system...but a serial console can help you make progress... Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com