On 09/14/2016 07:07 AM, Valo, Kalle wrote:
greearb@xxxxxxxxxxxxxxx writes:From: Ben Greear <greearb@xxxxxxxxxxxxxxx> When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error message for tx failures. Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> --- drivers/net/wireless/ath/ath10k/mac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index cd3016d..42cac32 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3432,8 +3432,9 @@ static int ath10k_mac_tx_submit(struct ath10k *ar, } if (ret) { - ath10k_warn(ar, "failed to transmit packet, dropping: %d\n", - ret); + if (net_ratelimit()) + ath10k_warn(ar, "failed to transmit packet, dropping: %d\n", + ret); ieee80211_free_txskb(ar->hw, skb); }ath10k_warn() is already rate limited. If there's something wrong then that function should be fixed, not the callers. void ath10k_warn(struct ath10k *ar, const char *fmt, ...) { struct va_format vaf = { .fmt = fmt, }; va_list args; va_start(args, fmt); vaf.va = &args; dev_warn_ratelimited(ar->dev, "%pV", &vaf); trace_ath10k_log_warn(ar, &vaf); va_end(args); }
The problem with having the ratelimit here is that you may miss rare warnings due to a flood of common warnings. That is why it is still useful to ratelimit potential floods of warnings. I would like to remove the ratelimit from ath10k_warn eventually. Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com
