Search Linux Wireless

Re: [PATCH 0/9] rsi: code clean-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx> writes:

> *** BLURB HERE ***

This has a meaning :)

> Prameela Rani Garnepudi (9):
>   rsi: cleanup and added debug prints in file rsi_91x_core.c
>   rsi: Spelling and code format corrections in rsi_91x_debugfs.c
>   rsi: Added freeing of allocated buffers (sbands and dfsentry)         
>     Cleanup (spelling mistakes, code format corrections,     	     
>     empty lines after declaration)
>   rsi: code clean up in file rsi_91x_main.c
>   rsi: code cleanup in file rsi_91x_mgmt.c
>   rsi: code cleanup (spelling mistakes and new line after declaration)
>     in file rsi_91x_sdio.c          Added developer name
>   rsi: zone changed for debug message and cleanup in file
>     rsi_91x_sdio_ops.c
>   rsi: code clean up and replaced ctrl message timeouts with macros in
>     file rsi_91x_usb.c
>   rsi: code cleanup in file rsi_91x_usb_ops.c

Usually patches are split based on type of changes, not by files
affected. So one patch does one type of logical change to all files in
the driver and another patch does again something else. Also the commit
logs are not correctly formatted, for example the title is too long.

I recommend to start with something small, for example one small patch a
time. And once you get more familiar with the process you can submit
more, and bigger, patches at a time. Also code cleanup is not really the
best way to start as it's a very subjective matter.

Also try to get more familiar how development is done, here are few
links:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

https://www.kernel.org/doc/Documentation/SubmittingPatches

https://kernelnewbies.org/FirstKernelPatch

Also mailing list archives and git logs are a great way to learn from
how others do it.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux