Hello Amitkumar, On 09/08/2016 11:55 AM, Amitkumar Karwar wrote: > Hi Javier, > >> From: Javier Martinez Canillas [mailto:javier@xxxxxxxxxxxxxxx] >> Sent: Tuesday, September 06, 2016 5:43 PM >> To: Kalle Valo >> Cc: linux-kernel@xxxxxxxxxxxxxxx; Amitkumar Karwar; >> netdev@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Nishant >> Sarmukadam; Arend van Spriel >> Subject: Re: mwifiex: propagate error if IRQ request fails in >> mwifiex_sdio_of() >> >> Hello Kalle, >> >> On 09/03/2016 12:35 PM, Kalle Valo wrote: >>> Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> wrote: >>>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error >>>> message is printed but the actual error is not propagated to the >> caller function. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >>> >>> What's the conclusion with this patch? Should I drop it or take it? >>> >>> (The discussion is available from the patchwork link in the >>> signature.) >>> >> >> My understanding is that Arend agrees with the patch and that the >> question raised was caused by looking at an older kernel version. IOW, >> the patch is OK and should be picked. >> >> I'm adding Arend to cc, so can comment in case I misunderstood him >> though. >> > > This error doesn't affect actual wifi functionality. Only thing is wakeup on interrupt when system is in suspended state won't work. > I think, we can make below change. > > ------------------ > @@ -122,9 +122,11 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) > IRQF_TRIGGER_LOW, > "wifi_wake", cfg); > if (ret) { > - dev_err(dev, > + dev_dbg(dev, > "Failed to request irq_wifi %d (%d)\n", > cfg->irq_wifi, ret); > + card->plt_wake_cfg = NULL; > + return 0; > } I'm OK with that change. Feel free too add my Reviewed-by if you post it. > disable_irq(cfg->irq_wifi); > } > ----------------- > > Regards, > Amitkumar > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
