Hi Kalle, > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Friday, September 02, 2016 8:26 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mwifiex: handle edmac vendor command > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > >> Sorry for the delay. I have been thinking about vendor commands quite > >> a lot and I don't think they belong to upstream drivers. For regular > >> use cases (used by normal users) we have nl80211, for developer and > >> testing purposes we have debugfs and for manufacturing type of tests > >> we have > >> nl80211 testmode interface. The focus of development should be adding > >> new functionality to nl80211 (and other generic interfaces), not to > >> driver specific vendor commands. > >> > >> I know brcm80211 and ti's wlcore have few vendor commands but I'm > >> hoping to remove them sometime soon. > >> > >> Thoughts? > >> > > > > Thanks for your reply. > > > > There is something called energy detect mode. Chip can detect non-WiFi > > radio signal also and monitor it for specified time before > > transmitting frames. As per ETSI specification, enabling this mode is > > mandatory for some countries for certain frequencies. > > To me this looks this is something which can be generic, not a driver > specific interface. And why can't regulatory code enable this > automatically, without any user involvement? It already knows what > country we are in. > Got it. I will check if we can make this as generic as you mentioned and explore the option. Regards, Amitkumar
