Hi Brian, > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: Thursday, September 01, 2016 1:10 AM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > Xinming Hu > Subject: Re: [v4,2/2] mwifiex: add cfg80211 testmode support > > On Tue, Jul 26, 2016 at 03:09:20PM +0530, Amitkumar Karwar wrote: > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > This patch adds cfg80211 testmode support so that userspace tools can > > download necessary commands to firmware during manufacturing mode > tests. > > > > Signed-off-by: Xinming <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > v4: Used cfg80211 testmode interface instead of wext in 2/2 > > patch.(Kalle Valo) > > v3: Add "select WIRELESS_EXT" in Kconfig to resolve kbuild test robot > errors. > > WEXT_PRIV seems to have a dependency with WIRELESS_EXT. > > v2: 1) Sequence of these two patches are changed to resolve > compilation > > error seen if only 1/2 is applied. > > 2) Add "select WEXT_PRIV" in Kconfig to resolve warnings reported > by > > kbuild test robot. > > --- > > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 83 > > +++++++++++++++++++++++++ > > 1 file changed, 83 insertions(+) > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > index 235fb39..86b31b1 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > @@ -3919,6 +3919,88 @@ static int mwifiex_cfg80211_get_channel(struct > wiphy *wiphy, > > return ret; > > } > > > > +#ifdef CONFIG_NL80211_TESTMODE > > + > > +enum mwifiex_tm_attr { > > + __MWIFIEX_TM_ATTR_INVALID = 0, > > + MWIFIEX_TM_ATTR_CMD = 1, > > + MWIFIEX_TM_ATTR_DATA = 2, > > + > > + /* keep last */ > > + __MWIFIEX_TM_ATTR_AFTER_LAST, > > + MWIFIEX_TM_ATTR_MAX = __MWIFIEX_TM_ATTR_AFTER_LAST - 1, > > +}; > > + > > +static const struct nla_policy mwifiex_tm_policy[MWIFIEX_TM_ATTR_MAX > + 1] = { > > + [MWIFIEX_TM_ATTR_CMD] = { .type = NLA_U32 }, > > + [MWIFIEX_TM_ATTR_DATA] = { .type = NLA_BINARY, > > + .len = MWIFIEX_SIZE_OF_CMD_BUFFER }, > }; > > + > > +enum mwifiex_tm_cmd { > > + MWIFIEX_TM_CMD_HOSTCMD = 0, > > +}; > > + > > +int mwifiex_tm_cmd(struct wiphy *wiphy, struct wireless_dev *wdev, > > This function should be static, no? > > Brian > Yes. This have been taken care of in V5 patch. Regards, Amitkumar Karwar
