Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> +static int invoke_tx_handlers(struct ieee80211_tx_data *tx) >> +{ >> + return invoke_tx_handlers_early(tx) || >> invoke_tx_handlers_late(tx); >> +} > > Ugh, please, no, don't be tricky where it's not necessary. Now every > person reading this has to first look up the return type, and then the > return value, and make sure they understand that success is actually > the value 0 ... that's way too much to ask. Noted. Any objections to turning these into bool return types? I'll go through and fix your other comments and send a new version. Thanks for the feedback :) -Toke