On 29 August 2016 at 17:42, Baoyou Xie <baoyou.xie@xxxxxxxxxx> wrote: > On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >> >> On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@xxxxxxxxxx> wrote: >> > We get 1 warning when build kernel with W=1: >> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: >> > warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes] >> >> building? I'm not native English, but I think so. >> >> >> > In fact, this function is declared in brcmfmac/debug.h, so this patch >> > add missing header dependencies. >> >> adds >> >> >> > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> >> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> >> >> Please don't resend patches just to add tags like that. This only >> increases a noise and patchwork handles this just fine, see: >> https://patchwork.kernel.org/patch/9303285/ >> https://patchwork.kernel.org/patch/9303285/mbox/ > > > it modifies a typo biuld/build. Please send your replies to all, not privately. OK, so you should also include a changelog in the comments part of diff, e.g.: V4: Fix typo in "biuld"