On 08/24/2016 11:18 PM, Michal Kazior wrote:
I was looking at firmware to make sure that I fixed what I could there....
From what I can tell, 10.4 should not have this bug. Did you see this only
on 10.1/10.2 firmware? It is of course possible that I am mis-understanding
10.4....
I did see it on 10.1 and 10.2. Don't recall seeing it on 10.4 though.
If you didn't see warnings on 10.4 even after adding msleep() as per
commit log then I guess it doesn't suffer from the bug.
I can still occasionally see that message with a 15000 ms sleep.
Based on debugging, it seems my firmware is now setting the mac-mask properly.
But, as you mention, the rxfilter is enabled very early. So, probably
it is still possible to see packets early if they are multicast, bcast, etc.
I don't think it is worth re-working the entire rx-filter calc in
the concurrency logic properly for 10.1 firmware, so I'm going to figure
my fix is good enough as is as long as it sets the mac-mask properly.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
