Search Linux Wireless

Re: [PATCH 1/3 v2] mac80211: RX BA support for sta max_rx_aggregation_subframes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	/* examine state machine */
> +	mutex_lock(&sta->ampdu_mlme.mtx);
> +
>  	/* make sure the size doesn't exceed the maximum supported
> by the hw */
> -	if (buf_size > local->hw.max_rx_aggregation_subframes)
> -		buf_size = local->hw.max_rx_aggregation_subframes;
> +	if (buf_size > sta->sta.max_rx_aggregation_subframes)
> +		buf_size = sta->sta.max_rx_aggregation_subframes;
>  	params.buf_size = buf_size;
> 
Since the driver is updating this value without any locking, is there
any point in changing the locking?

> +	ht_dbg(sta->sdata, "AddBA Req buf_size=%d\n", buf_size);

I think the station address should be in there.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux