On Mon, Aug 22, 2016 at 1:47 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Sunday, August 21, 2016 4:49:03 PM CEST Martin Blumenstingl wrote: >> We will default to the system's native endianness for the eepmisc value. >> This may be overwritten by the actual calibration data. If it is not >> overwritten we interpret the template data in it's native endianness, >> meaning that no swapping is required. > > I'm still skeptical about this one. What is the significance of "native > endianess" here? You are keying the endianess of the eeprom tables off the > way the CPU operates, but for a PCI device there is no correlation between > those two. (the ar9003 eeprom format and handling is different compared to 9287, def and 4k) ar9003_eeprom.c contains EEPROM templates -> these are compiled into the ath9k kernel module. Values from these templates can be overwritten by the EEPROM found on the actual hardware. This change tries to handle the case where the values in the hardware EEPROM do not override any of the template values (means final EEPROM data = template data). In this case the we can simply rely on the endianness which was used to compile ath9k.ko. I also noted that this is missing a signed-off-by tag as well (sorry for that, I will re-send it together with the other patch next weekend)
