Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
> On Wed, 2016-08-17 at 15:16 +0200, Toke Høiland-Jørgensen wrote:
>> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>>
>> >
>> > >
>> > > @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf {
>> > > u8 iv_len;
>> > > u8 hw_key_idx;
>> > > u8 flags;
>> > > + u8 pn_offs;
>> > >
>> > This is completely wrong.
>>
>> Well, the ieee80211_fast_tx struct is not available in
>> ieee80211_tx_dequeue, and I need the offset there. I thought about
>> sticking it into ieee80211_tx_info, but that is kinda full, and since
>> the ieee80211_key_conf is already available there, carrying it there
>> seems to work.
>
> For very limited testing, perhaps. But this isn't static across all
> usages of the key, so this is still completely broken.
OK, noted.
>> What would be a better way to do this?
>>
>
> Some redesign/rearchitecture, probably. Or just do it all in the driver
> like iwlmvm?
Will look it over again. Should be possible to re-calculate the offset,
I guess.
-Toke
