On Fri, 2016-08-12 at 20:26 -0700, David Miller wrote: > From: Petri Gynther <pgynther@xxxxxxxxxx> > Date: Fri, 12 Aug 2016 17:15:30 -0700 > > > Root cause: > > mwifiex driver calls is_zero_ether_addr() against byte-aligned address: > > MAC addresses really must be 16-bit aligned to be used with any of the > ethernet address manipulation and test interfaces. > > Therefore this driver should do whatever it takes to avoid passing > a byte-aligned MAC address anywhere. > > We _SHOULD NOT_ add support for byte aligned addresses to these > interfaces, nor add routines which by-name can handle them. My recollection is that batman uses unaligned addresses and some form of _unaligned tests are required there. It seems that other wireless drivers also use _unaligned in various forms. > Fix this driver instead of polluting out common interfaces > unnecessarily. One solution might be to copy a hardware interface structure to another struct with appropriate alignment. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
