> This patch could over write cfg->ht_opmode even though EINVAL. > I will modify this. > Don't think that actually matters since then it shouldn't be used, but the v3 patch looks good. I'm not sure we should bother to do cross-setting validation? Like, I mean, validating that non-GF and non-HT aren't set together, etc. Those are somewhat nonsense configurations, but we can't prevent them all. I'm actually half thinking that we could just remove all restrictions on this and allow any u16 value of this field, and rely on wpa_supplicant to do the right thing... Then we don't have to update this if we ever want to do something new either. What do you think? What does the validation actually help us with? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html