I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/net/wireless/ath/ath9k/init.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 2ee8624..5196633 100644 --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -42,33 +42,33 @@ module_param_named(debug, ath9k_debug, uint, 0); MODULE_PARM_DESC(debug, "Debugging mask"); int ath9k_modparam_nohwcrypt; -module_param_named(nohwcrypt, ath9k_modparam_nohwcrypt, int, 0444); +module_param_named(nohwcrypt, ath9k_modparam_nohwcrypt, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption"); int ath9k_led_blink; -module_param_named(blink, ath9k_led_blink, int, 0444); +module_param_named(blink, ath9k_led_blink, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(blink, "Enable LED blink on activity"); static int ath9k_led_active_high = -1; -module_param_named(led_active_high, ath9k_led_active_high, int, 0444); +module_param_named(led_active_high, ath9k_led_active_high, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(led_active_high, "Invert LED polarity"); static int ath9k_btcoex_enable; -module_param_named(btcoex_enable, ath9k_btcoex_enable, int, 0444); +module_param_named(btcoex_enable, ath9k_btcoex_enable, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(btcoex_enable, "Enable wifi-BT coexistence"); static int ath9k_bt_ant_diversity; -module_param_named(bt_ant_diversity, ath9k_bt_ant_diversity, int, 0444); +module_param_named(bt_ant_diversity, ath9k_bt_ant_diversity, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bt_ant_diversity, "Enable WLAN/BT RX antenna diversity"); static int ath9k_ps_enable; -module_param_named(ps_enable, ath9k_ps_enable, int, 0444); +module_param_named(ps_enable, ath9k_ps_enable, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave"); #ifdef CONFIG_ATH9K_CHANNEL_CONTEXT int ath9k_use_chanctx; -module_param_named(use_chanctx, ath9k_use_chanctx, int, 0444); +module_param_named(use_chanctx, ath9k_use_chanctx, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(use_chanctx, "Enable channel context for concurrency"); #endif /* CONFIG_ATH9K_CHANNEL_CONTEXT */ -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
