I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/net/wireless/ath/ath6kl/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/core.c b/drivers/net/wireless/ath/ath6kl/core.c index ebb9f16..6b5b18b 100644 --- a/drivers/net/wireless/ath/ath6kl/core.c +++ b/drivers/net/wireless/ath/ath6kl/core.c @@ -37,15 +37,15 @@ static unsigned int testmode; static unsigned int recovery_enable; static unsigned int heart_beat_poll; -module_param(debug_mask, uint, 0644); -module_param(suspend_mode, uint, 0644); -module_param(wow_mode, uint, 0644); -module_param(uart_debug, uint, 0644); -module_param(uart_rate, uint, 0644); -module_param(ath6kl_p2p, uint, 0644); -module_param(testmode, uint, 0644); -module_param(recovery_enable, uint, 0644); -module_param(heart_beat_poll, uint, 0644); +module_param(debug_mask, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(suspend_mode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(wow_mode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(uart_debug, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(uart_rate, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(ath6kl_p2p, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(testmode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(recovery_enable, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(heart_beat_poll, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(recovery_enable, "Enable recovery from firmware error"); MODULE_PARM_DESC(heart_beat_poll, "Enable fw error detection periodic polling in msecs - Also set recovery_enable for this to be effective"); -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
