On 27 July 2016 at 14:59, Thiagarajan, Vasanthakumar <vthiagar@xxxxxxxxxxxxxxxx> wrote: > On Wednesday 27 July 2016 06:13 PM, Michal Kazior wrote: >> On 27 July 2016 at 14:36, Vasanthakumar Thiagarajan [...] >>> --- a/drivers/net/wireless/ath/ath10k/core.c >>> +++ b/drivers/net/wireless/ath/ath10k/core.c >>> @@ -68,6 +68,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { >>> .board_size = QCA988X_BOARD_DATA_SZ, >>> .board_ext_size = QCA988X_BOARD_EXT_DATA_SZ, >>> }, >>> + .hw_rx_desc_ops = &qca988x_rx_desc_ops, >> [...] >>> +struct ath10k_hw_rx_desc_ops { >>> + int (*rx_desc_get_l3_pad_bytes)(struct htt_rx_desc *rxd); >>> +}; >> >> Benjamin is trying to implement coverage class by poking hw registers >> over firmware's head [1]. I'm thinking the hw_rx_desc_ops could be >> generalized to hw_ops so it can be used for doing hw-specific hacks as >> well. What do you think? > > Sure. Instead of reworking this patch set, can this be done in a separate patch?. I don't really mind especially since there's not much comments on his work yet. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html