On 13-7-2016 22:19, Alex Briskin wrote:
> Hi All,
> This is my first patch(s).
Hi Alex,
As these patches are touching mac80211 it would be good to use
'mac80211: ' prefix.
> I've decided to refactor ieee80211_iface_work function and break it down
> to smaller better defined function.
>
> I think these changes make the code much more readable and do not impose
> no overhead.
>
> I've tested these patches with sparse and checkpatch.pl
>
> Function names might not be descriptive enough.
> Hope you find this useful.
>
> Alex Briskin (4):
> 0) [28e464b19aaaba90c8946fb979b58709d55dffcf]
> Added new function ieee80211_is_skb_handled_by_pkt_type and moved
> some code from ieee80211_iface_work to reduce complexity and
> improve readability
>
> 1) [486e3d5abb4dc6361cdd923254a2b68d43dcdaba]
> Refactored code in ieee80211_is_skb_handled_by_pkt_type.
> "if () {} else if ()" replaced by switch case.
I would collapse these two patches in one patch.
> 2) [9ef2eab8e831420bc6748a4466ffa6b7a99bf447]
> Added new function ieee80211_is_handled_by_frame_control and moved
> some code from ieee80211_iface_work to it.
>
> 3) [1de8cdf9a0c05c6a21d9e43e5b55862f6efcf450]
> Added new function ieee80211_handle_by_vif_type with code from
> ieee80211_iface_work.
>
> At this point ieee80211_iface_work seems to me much more readable
> and better understood.
You are allowed to have an opinion :-) The function naming of the three
functions could be more consistent as you seem to drop a bit in every
patch, ie. is_skb_handled_by -> is_handled_by -> handle_by.
Regards,
Arend
> net/mac80211/iface.c | 264 +++++++++++++++++++++++++++++----------------------
> 1 file changed, 150 insertions(+), 114 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
