Hi Tamizh,
On Fri, Jul 1, 2016 at 5:06 PM, <c_traja@xxxxxxxxxxxxxxxx> wrote:
> From: Tamizh chelvam <c_traja@xxxxxxxxxxxxxxxx>
>
> Preparation to make use of firmware_swap_code_seg_info for UTF binary.
>
> Signed-off-by: Tamizh chelvam <c_traja@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 6 +++---
> drivers/net/wireless/ath/ath10k/core.h | 6 ++----
> drivers/net/wireless/ath/ath10k/swap.c | 26 ++++++++++++++------------
> drivers/net/wireless/ath/ath10k/swap.h | 11 ++++++++---
> 4 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 3da18c9..e69e7e7 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -654,6 +654,8 @@ struct ath10k_fw_file {
>
> const void *codeswap_data;
> size_t codeswap_len;
> + /* FIXME: add a comment */
> + struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info;
Why not just add a comment? Adding FIXMEs makes the patch look incomplete to me.
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
