On 2016-06-27 14:57, Mark Rutland wrote: > On Thu, Jun 23, 2016 at 08:14:29PM +0200, Martin Blumenstingl wrote: >> On Thu, Jun 23, 2016 at 7:58 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: >> > On Thu, Jun 23, 2016 at 07:45:35PM +0200, Martin Blumenstingl wrote: >> >> +- qca,eeprom-name: The name of the file which contains the EEPROM data (which >> >> + will be loaded via request_firmware) >> > >> > The binding shouldn't know anything about the host filesystem, >> > request_firmware, etc. So the description is a best a little off. >> > >> > What happens when a new FW comes out? I shouldn't have to update my DT >> > to cater for that. >> This is not exactly a "firmware" but rather device-specific >> calibration data (RF settings, MAC address, etc). Usually there is an >> eeprom connected directly to the wifi chip, but on embedded devices >> this is usually skipped and instead the calibration data is shipped >> somewhere on the main flash (directly on SPI-/NOR-/NAND flash, >> sometimes even inside an UBI volume). > > Ok. I believe that previously, for ath10k, it was suggested that this > calibration data be placed directly in the DT (assuming it's small > enough). I don't think the data should go directly into DT, because then we need a lot more complex kernel loader stubs. There are hundreds of devices out there with calibration data in flash, and many of them have the data in different places, and almost all of them don't support passing DT via boot loader. The actual RF settings are calibrated for every individual device, so they need to be read from the flash partition anyway. I think it makes sense to add an optional reference to a mtd partition and allow the kernel to read from it directly. >> > Please find a better way to identify relevant FW. What exactly affects >> > which FW can be used, or would ideally be used? Are different FWs >> > required for the same HW in some contexts? >> > >> > Can we not figure out the relevant FW names in the driver based on some >> > identification mechanism (e.g. a more thoroughly defined set of >> > compatible strings)? >> The only way of auto-detecting a "correct" name would be via >> dev_name() (with some prefix this could give something like >> ath9k-pci-0000:00:0e.0.bin). > > That may work, if the above is not an option. I think that's a good idea. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
