Search Linux Wireless

Re: [PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  	 */
> -	changed = mesh_accept_plinks_update(sdata);
> +	if (sdata->u.mesh.user_mpm &&
> +	    sta->mesh->plink_state == NL80211_PLINK_ESTAB)
> +		changed |= mesh_plink_dec_estab_count(sdata);
> +	changed |= mesh_accept_plinks_update(sdata);
>  	if (!sdata->u.mesh.user_mpm) {
>  		changed |= mesh_plink_deactivate(sta);
>  		del_timer_sync(&sta->mesh->plink_timer);
> 

Does it have to be done before the mesh_accept_plinks_update()?

If not, you should put it with the existing u.mesh.user_mpm check. If
yes, then the code is further buggy since only mesh_plink_deactivate()
will call it when the kernel MPM is used.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux