Search Linux Wireless

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21 June 2016 at 18:58, Ismael Luceno <ismael@xxxxxxxxxxx> wrote:
> On 21/Jun/2016 07:45, Rafał Miłecki wrote:
>> On 21 June 2016 at 02:18, Ismael Luceno <ismael@xxxxxxxxxxx> wrote:
>> > @@ -56,6 +57,8 @@
>> >
>> >  /* USB Device IDs */
>> >  #define BRCM_USB_43143_DEVICE_ID       0xbd1e
>> > +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
>> > +                                       0x0039
>>
>> I guess you wanted to have number aligned to the column of other ones?
>> I'm not sure if that improves readability at all.
>
> Yes. Would you suggest to align more to the right? I didn't want to
> modify everything just to add a new one.

I wouldn't care that much about alignment. I'm sure there already some
misaligned numbers, fields & comments in brcm80211 header.

I would just use name\t0x0039 pattern.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux