On Tue, Jun 21, 2016 at 07:10:28AM -0700, Ben Greear wrote: > > > On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >thanks for reporting ... > > > >On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote: > >>I'm working on bringing up my hacked up version of 4.7 ath10k and 10.4 firmware, and I think > >>I may have found a regression. > > > >[shafi] let me know what is the issue.. some steps to recreate the issue. > > ethtool -S wlan0 > or similar should reproduce it. > > You would see stats timeout messages in dmesg, and with a bit more debugging, > you notice that the driver is basically busy-spinning trying to get stats over > WMI and/or it is giving errors because skb pull fails because there actually is > not extd stats struct. https://patchwork.kernel.org/patch/9149357/ should help (Kalle had a cleaned up version in his pending branch > > >> > >>My 10.4.3-ish firmware source has a bunch of: > >> > >>if (stats_id == WMI_REQUEST_PEER_STAT) > >>logic in it. In other words, it is not using that id as a bitfield. > > > >[shafi] will check this. > > I fixed my firmware to treat it as a bitfield, and to specifically un-set the EXTD stats > bit, and now it works with my 4.7. Firmware fix should be backwards compatible. > > > >>Now, I can fix the firmware, but I am guessing that at least some stock > >>10.4 firmware has this same issue, and of course any older firmware > >>that does not have this change will still be broken. > >> > >>So, do you want to back out this patch below, at least the part where it sends > >>in 0x9 as the stats_id? > > > >[shafi] request if you can check this please, there was some misunderstanding > >in the design when this feature got enabled in 10.4, we fixed it in > >https://patchwork.kernel.org/patch/9149357/ > > That might have fixed it, but it is not in 4.7, so I didn't have it > in my tree when testing yesterday. > > Thanks, > Ben > > -- > Ben Greear <greearb@xxxxxxxxxxxxxxx> > Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
