Search Linux Wireless

Re: mwifiex: remove misleading GFP_DMA flag in buffer allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote:
> The GFP_DMA flag is obviously misunderstood in the mwifiex driver. It's
> meant for legacy ISA DMA memory mappings only -- the lower 16MB on x86.
> That doesn't apply to PCIe or SDIO devices, I guess.
> 
> Remove the GFP_DMA flag to reduce the need to place the socket buffer
> allocation into the low mem DMA area, which might already be in use by
> other drivers.
> 
> This misuse was flagged by the PaX USERCOPY feature by chance, as it
> detected the user copy operation from a DMA buffer in the recvfrom()
> syscall path.
> 
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> Tested-by: Dennis Wassenberg <dennis.wassenberg@xxxxxxxxxxx>
> Cc: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> Cc: Nishant Sarmukadam <nishants@xxxxxxxxxxx>
> Cc: Xinming Hu <huxm@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: Brad Spengler <spender@xxxxxxxxxxxxxx>
> Cc: PaX Team <pageexec@xxxxxxxxxxx>
> Acked-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>

Thanks, 1 patch applied to wireless-drivers-next.git:

5c87a55adbd5 mwifiex: remove misleading GFP_DMA flag in buffer allocations

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9130575/

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux