Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> writes: > Hi! > > This set moves to a global header file macros which I find > very useful and worth popularising. The basic problem is > that since C bitfields are not very dependable accessing > subfields of registers becomes slightly inconvenient. > It is nice to have the necessary mask and shift operations > wrapped in a macro. It is also nice to have that macro > compute the shift amount based on the mask automatically. > > My implementation follows what Felix Fietkau has done in > mt76. Hannes Frederic Sowa suggested more use of standard > Linux/GCC functions. Since the RFC I've also added a > compile-time check to validate that the value passed to > setters fits in the mask. > > I attempted the use of static inlines instead of macros > but it makes GCC < 6.0 barf at the BUILD_BUG_ON()s. > I also noticed that forcing arguments to be u32 for inlines > makes the compiler use 32bit arithmetic where it could > get away with 64bit before (on 64bit machines, obviously). > That's a potential performance concern but probably not > a very practical one today. Apart from looking "cleaner" > static inlines would have the advantage that we could #undef > the auxiliary macros at the end of the header. > > Please review and advise on improvements. > > If accepted I think would be best to push this through > Kalle's tree, since the only existing user is in > drivers/net/wireless/. > > Jakub Kicinski (2): > add basic register-field manipulation macros > mt7601u: use linux/bitfield.h I guess you forgot to CC linux-wireless, adding it now, and hence I don't see these in my patchwork either. So better to resend. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
