Search Linux Wireless

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/15/2016 01:20 PM, Johannes Berg wrote:
On Tue, 2016-03-15 at 09:10 -0700, Ben Greear wrote:

The logic I wrote is basically exactly this.  It uses the configured
rates to specify which of the hardware's rates are allowed and
disabled.


I understand that. I just take issue with the fact that we have to
sprinkle "magic pixie dust" (in form of the override function calls)
everywhere throughout the code.

johannes


So, I never could think up a way to make this more acceptable and meet
my own goals.

Any chance I could get just the netlink enum in place, even if it is
called something like 'api_placeholder_x'?

Otherwise, it is about impossible for me to keep any sane forward/back
compatibility with my hostap patches....

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index c0ab6b0..4573f87 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -2130,6 +2130,8 @@ enum nl80211_attrs {

 	NL80211_ATTR_REG_INDOOR,

+	NL80211_ATTR_TX_ADVERT_RATEMASK,
+
 	/* add attributes here, update the policy in nl80211.c */

 	__NL80211_ATTR_AFTER_LAST,


Or, is there some other way to handle out-of-tree netlink stuff better?

Thanks,
Ben


--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux