On 06/03/2016 08:52 AM, Valo, Kalle wrote:
Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
On 06/02/2016 08:26 AM, Valo, Kalle wrote:
Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
I found a lot of problems with this code as well, and the 5 patches
starting from the URL below fixed the issues for me.
They are stuck as 'NA' in patchwork, but I don't know why.
http://lists.infradead.org/pipermail/ath10k/2016-April/007218.html
ath10k has a separate patchwork instance, did you look at the correct
one? I have quite a lot of patches from you in deferred state because of
the patch bomb, but I'm hoping to go through them soon.
https://patchwork.kernel.org/project/ath10k/list/?state=10&delegate=25621&order=date
Ok, they are deferred then.
The series of 5 is likely quite useful and fixes some nasty bugs,
and the first patch of the big bomb is also a trivial crash fix
for a regression you added (as best as I can tell).
The rest of the patch bomb is less critical, but making some progress on
that would make me feel good about working on ath10k patches again.
If I get a big patchset like 25 patches it immediately goes to the
bottom of the queue. Organising them a bit better takes like 15 minutes
of your time and makes it a lot easier to review. For example, you could
have split the patches into three sets: important bug fixes, firmware
debugging and the rest. That helps everyone and saves time.
The first 5 were posted a month earlier than the 25 patchset, and are
bug fixes. Whatever reason you ignored them, it wasn't because
there were 25 patches from me on the list at the time.
The second big series has the first patch as bug-fix, and clearly noted
in the 0000 description. Grab it, and save the rest for later.
I'll be happy to re-work the big patch-set, but there is a lot of churn in
ath10k, and waiting months before applying patches means they rot and makes
more work for everyone. Let's get these 6 bug-fixes in, and then I'll rebase,
test, and post a smaller patch-set for consideration.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
