On 31 May 2016 at 12:16, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2016-05-20 at 12:13 +0200, Rafał Miłecki wrote: >> Channels (frequencies) are getting more details that users may want >> to >> know about. E.g. it's important to know which frequencies allow using >> 40/80/160 MHz channels to setup AP properly. >> >> We list channels in "info" command output but it's already quite big >> and >> it was agreed to introduce new command rather than expand the old >> one. >> >> This patch adds "channels" command printing what was already >> available >> in the "info" plus details about supported channel widths. It also >> removes DFS info from the "info" output. > > Very nice. > > Unfortunately, I get compiler warnings about width_* being possibly > used uninitialized. Can you address that please? It's nice your compiled got this mistake, my didn't. There were actually meant to be static. I'll fix that. >> +TOPLEVEL(channels, NULL, NL80211_CMD_GET_WIPHY, 0, CIB_PHY, >> handle_channels, "Show available channels."); > > Maybe that should be allowed for a CIB_DEV too? Since this is PHY specific, I was thinking it should be CIB_PHY. I didn't see reason to allow querying devices. Similarly we don't support "iw dev wlan0 reg get". Anyway, I can change that if you think it's better for some reason. Any hint how to make command usable with both: phy and dev? -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
