On Mon, 2016-05-30 at 10:30 +1000, Julian Calaby wrote: > Hi All, > > On Sun, May 29, 2016 at 1:30 PM, Kirtika Ruchandani > <kirtika.ruchandani@xxxxxxxxx> wrote: > > > > This patch fixes the following checkpatch.pl warnings about > > comments in nl80211.c : > > - networking block comments don't use an empty '/*' line > > - block comments use a trailing '*/' on a separate line > > > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchandani@xxxxxxxxx> > The change and logic behind it are sound, so it gets my: > > Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx> > > however I'm concerned that this file is a deliberate exception to the > networking comment rules. > It's kinda mixed, I never really enforced one style or the other ... I'm kinda taking both now, with a slight preference towards the networking style perhaps (to please davem :) ) That said, in general I'm not really sure of the value of all of these patches - perhaps the kcalloc() one makes sense, not for checkpatch reasons but rather for size limit/integer overflow reasons, and the ether address assign for general readability, but overall ... I'll have to make up my mind :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
