Hi Aurimas, On Fri, May 13, 2016 at 2:16 AM, Aurimas Liutikas <aurimas@xxxxxxxxxx> wrote: You really should add a little more explanation here and include the exact compiler output you're fixing and mention that this option is only available with Clang. > Signed-off-by: Aurimas Liutikas <aurimas@xxxxxxxxxx> Other than that, it looks good to me. Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx> One final note, any patch you send to linux-wireless gets entered into patchwork, so there's no need to keep asking for a review, people are busy and will get to it eventually. Thanks, Julian Calaby > diff --git a/iw.c b/iw.c > index 2aabddb..a6efe5b 100644 > --- a/iw.c > +++ b/iw.c > @@ -516,7 +516,7 @@ int main(int argc, char **argv) > const struct cmd *cmd = NULL; > > /* calculate command size including padding */ > - cmd_size = abs((long)&__section_set - (long)&__section_get); > + cmd_size = labs((long)&__section_set - (long)&__section_get); > /* strip off self */ > argc--; > argv0 = *argv++; > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
