Search Linux Wireless

Re: [PATCH v1 1/1] rtl8xxxu: tuse %*ph to dump buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-05-26 at 17:52 +0300, Andy Shevchenko wrote:
> Use %*ph specifier to dump small buffers in hex format instead of doing this
> byte-by-byte.
[]
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
[]
> @@ -413,13 +413,8 @@ static int rtl8192cu_parse_efuse(struct rtl8xxxu_priv *priv)
>  		dev_info(&priv->udev->dev,
>  			 "%s: dumping efuse (0x%02zx bytes):\n",
>  			 __func__, sizeof(struct rtl8192cu_efuse));
> -		for (i = 0; i < sizeof(struct rtl8192cu_efuse); i += 8) {
> -			dev_info(&priv->udev->dev, "%02x: "
> -				 "%02x %02x %02x %02x %02x %02x %02x %02x\n", i,
> -				 raw[i], raw[i + 1], raw[i + 2],
> -				 raw[i + 3], raw[i + 4], raw[i + 5],
> -				 raw[i + 6], raw[i + 7]);
> -		}
> +		for (i = 0; i < sizeof(struct rtl8192cu_efuse); i += 8)
> +			dev_info(&priv->udev->dev, "%02x: %8ph\n", i, &raw[i]);

print_hex_dump_bytes?

or maybe add a dev_print_hex_dump variant?

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux