Hi Dan, Add a "rtl8xxxu:" prefix to the patch title. This makes it easier to determine which patch is for which driver when only the titles are listed. On Wed, May 18, 2016 at 8:48 AM, Dan Lenski <dlenski@xxxxxxxxx> wrote: > This patch: > > - increases the default value for the maximum number of polling loops to > wait for the rtl8xxxu MCU to start after the firmware is loaded (from > 1000 to 5000) > - makes this a configurable module parameter Split this into two patches, one to make it configurable and one to increase the default. > With RTL8723AU chipset, I frequently encounter "Firmware failed to start" > errors from rtl8xxxu after a cold boot. > > It appears that other chipsets supported by the driver have the same > problem. Here are a couple of relevant bug reports: > - http://ubuntuforums.org/showthread.php?t=2321756 > - https://www.mail-archive.com/ubuntu-bugs-nLRlyDuq1AZFpShjVBNYrg <at> public.gmane.org/msg4942468.html > > This issue seems to occur because RTL8XXXU_FIRMWARE_POLL_MAX (1000) is > too short, and the MCU fails to start up as quickly as expected. > > With a longer value (5000), the driver starts up consistently and > successfully after cold-boot. No signed-off-by. > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 11 +++++++---- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- > 2 files changed, 8 insertions(+), 5 deletions(-) Other than those things, the actual changes look fine to me. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
