I can't even describe how much I hate the concept of the reorder buffer in general. Ordering is the endpoints problem. Someday, after we get fq_codeled, short queues again, I'll be able to show why. On Mon, May 16, 2016 at 4:41 AM, Luca Coelho <luca@xxxxxxxxx> wrote: > On Fri, 2016-05-13 at 11:54 +0300, Dan Carpenter wrote: >> Hello Sara Sharon, >> >> The patch b915c10174fb: "iwlwifi: mvm: add reorder buffer per queue" >> from Mar 23, 2016, leads to the following static checker warnings: >> >> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:912 >> iwl_mvm_rx_mpdu_mq() >> error: potential NULL dereference 'sta'. >> >> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:912 >> iwl_mvm_rx_mpdu_mq() >> error: we previously assumed 'sta' could be null (see line 796) > > Thanks for the analysis and report, Dan! > > I have queued a fix for this through our internal tree. > > -- > Cheers, > Luca. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dave Täht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
