On Tue, May 20, 2008 at 5:41 PM, Tomas Winkler <tomasw@xxxxxxxxx> wrote:
> On Tue, May 20, 2008 at 8:01 PM, Stefanik Gábor <netrolller.3d@xxxxxxxxx> wrote:
>> This patch fixes packet injection on iwlwifi devices (iwl3945 and
>> iwl4965). Tested with packetspammer and aireplay-ng, also works in
>> monitor-while-associated mode. If possible, please apply to 2.6.26,
>> else to 2.6.27. The patch is also available as an attachment, in case
>> Gmail decides to word-wrap or whitespace-damage the inline version.
>>
>> Signed-off-by: Gábor Stefanik <netrolller.3d@xxxxxxxxx>
>> ---
>>
>> <snip>
>
> This is certainly no go for 4965. Station must be present in uCode
> table. Maybe this work for monitor mode but there is a race in regular
> cases, when sta_id != broadcast id at least priv->assoc_station_added
> == 1 has to be true. Have you tested it with 4965 ?
>
> I suggest to proceed with 3945 part only of this patch.
>
> Tomas
Which change does this comment apply to? The "IWL_DEBUG_DROP("Dropping
- !priv->vif\n");" one? Or the "drop all data frame if we are not
associated" one? Also, doesn't the "if (sta_id ==
IWL_INVALID_STATION)" part protect against such cases? Also, what
happens if we simply pass broadcast in such a case?
Thanks,
Gábor
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
