2016-05-06 17:02 GMT+01:00 Kalle Valo <kvalo@xxxxxxxxxxxxxx>: > Jaap Jan Meijer <jjmeijer88@xxxxxxxxx> writes: > >> 2016-05-06 16:12 GMT+01:00 Kalle Valo <kvalo@xxxxxxxxxxxxxx>: >>> Jaap Jan Meijer <jjmeijer88@xxxxxxxxx> writes: >>> >>>> Hi Kalle, >>>> >>>> Op vr 6 mei 2016 12:52 schreef Kalle Valo <kvalo@xxxxxxxxxxxxxx>: >>>> >>>> >>>> This has multiple issues: >>>> >>>> o Use your full name. >>>> o Use prefix "brcmfmac: " in the title. >>>> >>>> o I can't find commit f654d13, is the commit id really correct? >>>> o Also check from SubmittingPatches how you should reference commit ids. >>>> >>>> >>>> >>>> Thank you for the feedback, I will send a reworked patch as soon as I get home >>>> next week. Also I did this against v4.4.8 so I'll have to rebase it as well. >>>> >>>> I'm not sure what went wrong with the commit hash, its actually this commit: >>>> 1f0dc59a6de93586fcfc04696a61946408ffc56a. >>> >>> That commit id looks to be valid. >>> >>>> I see you did this commit, maybe you can check if this actually is the root >>>> cause? I'm sure you have a lot more insight into this issue than I do. > > I just commited the patch. Broadcom folks (CCed) should be able to > answer better, most likely they missed this patch as the title didn't > have "brcmfmac". > > -- > Kalle Valo Thanks, so no need to send a revised patch? Also, could you please point me to the right repository so I can follow the progress? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
