On 5 May 2016 at 17:21, Dave Taht <dave.taht@xxxxxxxxx> wrote: > On Thu, May 5, 2016 at 4:00 AM, Michal Kazior <michal.kazior@xxxxxxxxx> wrote: >> This adds a few debugfs entries to make it easier >> to test, debug and experiment. > > I might argue in favor of moving all these (inc the fq ones) into > their own dir, maybe "aqm" or "sqm". > > The mixture of read only stats and configuration vars is a bit confusing. > > Also in my testing of the previous patch, actually seeing the stats > get updated seemed to be highly async or inaccurate. For example, it > was obvious from the captures themselves that codel_ce_mark-ing was > happening, but the actual numbers out of wack with the mark seen or > fq_backlog seen. (I can go back to revisit this) That's kind of expected since all of these bits are exposed as separate debugfs entries/files. To avoid that it'd be necessary to provide a single debugfs entry/file whose contents are generated on open() while holding local->fq.lock. But then you could argue it should contain all per-sta-tid info as well (backlog, flows, drops) as well instead of having them in netdev*/stations/*/txqs. Hmm.. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
