On Tue, May 3, 2016 at 7:46 PM, Krishna Chaitanya <chaitanya.mgit@xxxxxxxxx> wrote: > On Tue, May 3, 2016 at 6:44 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote: >>> Hi, >>> >>> When the HW is in PS and Dynamic PS is enabled we are dropping >>> all the offchannel frames. Sequence is as below >>> >>> if hw is in PS: stop_queues reason=PS, queue dynamic_ps_disable_work >>> send Offchannel mgmt_tx >>> drop the packet because offchanel + stop_reasons[q] !=0 >>> >>> How should we handle this? SW RoC is handling this >>> by checking for offchannel and bringing the HW out of PS before >>> handing the packet to TX path, so it works fine. >> >> You should handle this by not doing such a non-sensical thing and >> finally implementing powersave properly in the driver :) > i don't see any issues in the powersave w.r.t driver. Isn't it a > valid case? you meant implementing dynamic_ps? If it advertise HW_SUPPORTS_DYNAMIC_PS it works fine. so may be we should queue those frames and send it to HW once it is out of powersave? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html