On Fri, 2016-04-29 at 09:26 +1000, Julian Calaby wrote: > > + > > +# Silence some warnings for now. Needs to be fixed upstream. > > b/26105799 > Comments like this worry me: who is being referred to as "upstream", > what are these warnings and why has nobody fixed them? > It's funny, because we're upstream (the kernel.org iw repository I maintain) and they're submitting a Makefile to the same upstream - saying that "upstream" should fix warnings. In reality, it's a deluded comment - the warnings from -Wunused- parameter are entirely useless and cannot be fixed without cluttering the code with __maybe_unused (or so) since the functions implement APIs. This alone is a reason to reject this patch. If there are legitimate warnings, submit patches first to fix them (and perhaps add the relevant warning to the real Makefile). If I then reject those "fixes", don't put such a baselessly accusatory comment into the Makefile. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
