On Mon, May 19, 2008 at 3:41 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> Again, mac should rather solve the problem that we do not connect to >> AP's that are not in the BSS list > > You're talking about this a lot without showing any willingness to work > on it. Personally, I don't care so I'm not going to work on making this > a valid assertion, obviously it is not. You are absolutely right I can imagine how it sounds, just I wish I had more time. So for now I'm just talking. If nobody will fix it till I clean my table I will fix it. >> The other issue is that we call ieee80211_rx_bss_put(dev, bss); before >> this call in ieee80211_send_assoc. > > Indeed, we (i.e. not just me!) should have caught this at the time the > original patch was merged. :) > Helmut, can you please make a patch that addresses both issues by > instead moving the compatible rates check into the "if (bss)" part in > ieee80211_send_assoc() right after ieee80211_rx_bss_get()? And you can > make "u64 rates = ~0;" the default to address the !bss case. > Still not sure in what flow the bss can be removed from the list. send_assoc() is called after mac has received successful authentication response. I would like to see a trace of this. Is this easily reproducible ? Thanks Tomas > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
