> -----Original Message----- > From: Malinen, Jouni [mailto:jouni@xxxxxxxxxxxxxxxx] > Sent: Wednesday, April 6, 2016 12:40 PM > To: Grumbach, Emmanuel <emmanuel.grumbach@xxxxxxxxx> > Cc: johannes@xxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; > Otcheretianski, Andrei <andrei.otcheretianski@xxxxxxxxx> > Subject: Re: [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report > NAN function termination > > On Tue, Mar 29, 2016 at 12:35:04PM +0300, Emmanuel Grumbach wrote: > > Provide a function that reports NAN DE function termination. The > > function may be terminated due to one of the following reasons: user > > request, ttl expiration or failure. > > > diff --git a/include/uapi/linux/nl80211.h > > b/include/uapi/linux/nl80211.h > > > +/** > > + * enum nl80211_nan_func_term_reason - NAN functions termination > > +reason > > + * > > + * Defines termination reasons of a NAN function > > + * > > + * @NL80211_NAN_FUNC_TERM_REASON_USER_REQUEST: requested > by user > > + * @NL80211_NAN_FUNC_TERM_REASON_TTL_EXPIRED: timeout > > + * @NL80211_NAN_FUNC_TERM_REASON_ERROR: errored */ enum > > +nl80211_nan_func_term_reason { > > + NL80211_NAN_FUNC_TERM_REASON_USER_REQUEST, > > + NL80211_NAN_FUNC_TERM_REASON_TTL_EXPIRED, > > + NL80211_NAN_FUNC_TERM_REASON_ERROR, > > +}; > > Can you please add > NL80211_NAN_FUNC_TERM_REASON_VENDOR_SPECIFIC? That would help > vendors to implement and send vendor specific reason codes if any. > The termination reasons are defined in the spec. Also adding a single enum value will not help much if the vendor has multiple error codes. So I think this info should be in a different attribute, if needed. Andrei. > -- > Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
