On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > Define several attributes that may be configured by user space > when starting NAN functionality (master preference and dual > band operation) > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h > @@ -826,6 +826,16 @@ > + * @NL80211_CMD_START_NAN: Start NAN operation, identified by its > + * %NL80211_ATTR_WDEV interface. This interface must have been previously > + * created with %NL80211_CMD_NEW_INTERFACE. After it has been started, the > + * NAN interface will create or join a cluster. This command must have a > + * valid %NL80211_ATTR_NAN_MASTER_PREF attribute and optional > + * %NL80211_ATTR_NAN_DUAL attributes. > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > +static int nl80211_start_nan(struct sk_buff *skb, struct genl_info *info) > + if (!info->attrs[NL80211_ATTR_NAN_MASTER_PREF]) > + return -EINVAL; Why NL80211_ATTR_NAN_MASTER_PREF is mandatory? The spec suggests to assume master preference value of 128 if not provided. Please see quoted text from NAN 1.0 specification: "A NAN Device which out-of-the-box will have a Master Preference greater than or equal to 128 with the intention of being a NAN Master Device" -- Jouni Malinen PGP id EFC895FA-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
