Search Linux Wireless

Re: [PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	NL80211_ATTR_NAN_FUNC_INST_ID,

I don't see why this has to be a top-level attribute.

> +enum nl80211_nan_func_attributes {
> +	__NL80211_NAN_FUNC_INVALID,
> +	NL80211_NAN_FUNC_TYPE,

You can easily move it into here, and 

> +	/* propagate the instance id and cookie to userspace  */
> +	if (WARN_ON(nla_put_u8(msg, NL80211_ATTR_NAN_FUNC_INST_ID,
> +			       func.instance_id) ||
> +		    nla_put_u64(msg, NL80211_ATTR_COOKIE,
> func.cookie))) {

use the appropriate nesting here.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux