Hi, The implementation seems fine now, but I think the commit log needs some work. > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' I think it'd be worthwhile to describe the attribute a bit more, including why you're adding it. > This flag There's no flag. > will be set when drivers can fill rx_duration (aggregate > PPDU duration(usecs) for all the frames from a peer) You have the description here, but putting it with the attribute would be better. > via 'drv_sta_statistics' callback drv_sta_statistics is a mac80211 detail, that's not relevant at cfg80211 level; mentioning that is just confusing. This can well used by non-mac80211 drivers. > Also make sta_info flags 'filled' as 64 bit to accommodate for new > per station stats. That sentence doesn't parse well. > Extend 'PUT_SINFO' for supporting rx_duration > field and any new per sta information in future That sentence I think should just be removed. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
