On 03/31/2016 11:12 PM, Michal Kazior wrote:
On 31 March 2016 at 22:59, <greearb@xxxxxxxxxxxxxxx> wrote:From: Ben Greear <greearb@xxxxxxxxxxxxxxx> Otherwise, the txrx-compl-task may access some bad memory? Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> --- drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c index 07b960e..58e88d3 100644 --- a/drivers/net/wireless/ath/ath10k/htt_tx.c +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c @@ -376,6 +376,8 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt) { int size; + tasklet_kill(&htt->txrx_compl_task); +I think, instead, the ordering of ath10k_htt_tx_free() and ath10k_htt_rx_free() should be reversed. It's already in the "correct" order in ath10k_core_stop() on error path.
That seems a bit too subtle for my taste, but either way is fine with me. You want to cook up a patch? Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
